SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Make boolean properties of ActivityInputAttribute non-nullable

Browse source 
Fixes #1390.
This commit is contained in:
Sipke Schoorstra 2021-09-03 13:10:00 +02:00
parent e04a910d96
commit b007dc7574
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Elsa.sln.DotSettings
View file

@ -7,6 +7,7 @@
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/SPACE_WITHIN_SINGLE_LINE_ARRAY_INITIALIZER_BRACES/@EntryValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_LINES/@EntryValue">False</s:Boolean>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=EF/@EntryIndexedValue">EF</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=UI/@EntryIndexedValue">UI</s:String>
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpKeepExistingMigration/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpPlaceEmbeddedOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpUseContinuousIndentInsideBracesMigration/@EntryIndexedValue">True</s:Boolean>

6
src/core/Elsa.Abstractions/Attributes/ActivityInputAttribute.cs
View file

@ -58,12 +58,12 @@ namespace Elsa.Attributes
/// <summary>
/// A value indicating whether this property should be displayed but as read-only.
/// </summary>
public bool? IsReadOnly { get; set; }
public bool IsReadOnly { get; set; }
/// <summary>
/// A value indicating whether this property should be visible.
/// </summary>
public bool? IsBrowsable { get; set; }
public bool IsBrowsable { get; set; } = true;
/// <summary>
/// A value indicating whether this property MUST be evaluated at runtime to support the workflow designer.

4
src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs
View file

@ -96,8 +96,8 @@ namespace Elsa.Metadata
_defaultValueResolver.GetDefaultValue(propertyInfo),
activityPropertyAttribute.DefaultSyntax,
activityPropertyAttribute.SupportedSyntaxes,
activityPropertyAttribute.IsReadOnly ?? false,
activityPropertyAttribute.IsBrowsable ?? true,
activityPropertyAttribute.IsReadOnly,
activityPropertyAttribute.IsBrowsable,
activityPropertyAttribute.IsDesignerCritical,
activityPropertyAttribute.DefaultWorkflowStorageProvider,
activityPropertyAttribute.DisableWorkflowProviderSelection