From b007dc757416ef8b7bbfdcf5e540035f7b478771 Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Fri, 3 Sep 2021 13:10:00 +0200
Subject: [PATCH] Make boolean properties of ActivityInputAttribute
 non-nullable

Fixes #1390.
---
 Elsa.sln.DotSettings                                        | 1 +
 .../Elsa.Abstractions/Attributes/ActivityInputAttribute.cs  | 6 +++---
 src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs   | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/Elsa.sln.DotSettings b/Elsa.sln.DotSettings
index 2510bdecb..1fed07623 100644
--- a/Elsa.sln.DotSettings
+++ b/Elsa.sln.DotSettings
@@ -7,6 +7,7 @@
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/SPACE_WITHIN_SINGLE_LINE_ARRAY_INITIALIZER_BRACES/@EntryValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_LINES/@EntryValue">False</s:Boolean>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=EF/@EntryIndexedValue">EF</s:String>
+	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=UI/@EntryIndexedValue">UI</s:String>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpKeepExistingMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpPlaceEmbeddedOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpUseContinuousIndentInsideBracesMigration/@EntryIndexedValue">True</s:Boolean>
diff --git a/src/core/Elsa.Abstractions/Attributes/ActivityInputAttribute.cs b/src/core/Elsa.Abstractions/Attributes/ActivityInputAttribute.cs
index 7e86cfc65..6ddcfe7dc 100644
--- a/src/core/Elsa.Abstractions/Attributes/ActivityInputAttribute.cs
+++ b/src/core/Elsa.Abstractions/Attributes/ActivityInputAttribute.cs
@@ -58,12 +58,12 @@ namespace Elsa.Attributes
         /// <summary>
         /// A value indicating whether this property should be displayed but as read-only.
         /// </summary>
-        public bool? IsReadOnly { get; set; }
-        
+        public bool IsReadOnly { get; set; }
+
         /// <summary>
         /// A value indicating whether this property should be visible.
         /// </summary>
-        public bool? IsBrowsable { get; set; }
+        public bool IsBrowsable { get; set; } = true;
         
         /// <summary>
         /// A value indicating whether this property MUST be evaluated at runtime to support the workflow designer.
diff --git a/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs b/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs
index ea1d8e6d0..3742744e8 100644
--- a/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs
+++ b/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs
@@ -96,8 +96,8 @@ namespace Elsa.Metadata
                     _defaultValueResolver.GetDefaultValue(propertyInfo),
                     activityPropertyAttribute.DefaultSyntax,
                     activityPropertyAttribute.SupportedSyntaxes,
-                    activityPropertyAttribute.IsReadOnly ?? false,
-                    activityPropertyAttribute.IsBrowsable ?? true,
+                    activityPropertyAttribute.IsReadOnly,
+                    activityPropertyAttribute.IsBrowsable,
                     activityPropertyAttribute.IsDesignerCritical,
                     activityPropertyAttribute.DefaultWorkflowStorageProvider,
                     activityPropertyAttribute.DisableWorkflowProviderSelection