Fix dependency issues

This commit is contained in:
Sipke Schoorstra 2023-01-13 20:10:05 +01:00
parent 8ec2aa5b36
commit c6ceb247e1
7 changed files with 36 additions and 16 deletions

View file

@ -33,6 +33,6 @@ public class EFCoreWorkflowManagementPersistenceFeature : PersistenceFeatureBase
base.Apply();
AddStore<WorkflowInstance, EFCoreWorkflowInstanceStore>();
AddStore<WorkflowInstance, EFCoreWorkflowInstanceStore>();
AddStore<WorkflowDefinition, EFCoreWorkflowDefinitionStore>();
}
}

View file

@ -1,6 +1,4 @@
using Elsa.Workflows.Runtime.Features;
using Elsa.Workflows.Runtime.Implementations;
using Microsoft.Extensions.DependencyInjection;
namespace Elsa.EntityFrameworkCore.Modules.Runtime;
@ -26,13 +24,4 @@ public static class Extensions
feature.Module.Configure(configure);
return feature;
}
/// <summary>
/// Configures the workflow runtime to send workflow state to the <see cref="AsyncWorkflowStateExporter"/>.
/// </summary>
public static WorkflowRuntimeFeature UseAsyncWorkflowStateExporter(this WorkflowRuntimeFeature feature)
{
feature.WorkflowStateExporter = sp => ActivatorUtilities.CreateInstance<AsyncWorkflowStateExporter>(sp);
return feature;
}
}

View file

@ -29,6 +29,7 @@ namespace Elsa.Workflows.Management.Features;
[DependsOn(typeof(MediatorFeature))]
[DependsOn(typeof(SystemClockFeature))]
[DependsOn(typeof(WorkflowsFeature))]
[DependsOn(typeof(WorkflowDefinitionsFeature))]
public class WorkflowManagementFeature : FeatureBase
{
private const string PrimitivesCategory = "Primitives";

View file

@ -39,4 +39,10 @@ public static class ModuleExtensions
feature.Module.Configure(configure);
return feature;
}
public static WorkflowRuntimeFeature UseAsyncWorkflowStateExporter(this WorkflowRuntimeFeature feature, Action<AsyncWorkflowStateExporterFeature>? configure = default)
{
feature.Module.Configure(configure);
return feature;
}
}

View file

@ -0,0 +1,26 @@
using Elsa.Features.Abstractions;
using Elsa.Features.Attributes;
using Elsa.Features.Services;
using Elsa.Workflows.Management.Features;
using Elsa.Workflows.Runtime.Implementations;
using Microsoft.Extensions.DependencyInjection;
namespace Elsa.Workflows.Runtime.Features;
/// <summary>
/// Configures and enables <see cref="AsyncWorkflowStateExporter"/>.
/// </summary>
[DependsOn(typeof(WorkflowInstancesFeature))]
public class AsyncWorkflowStateExporterFeature : FeatureBase
{
/// <inheritdoc />
public AsyncWorkflowStateExporterFeature(IModule module) : base(module)
{
}
/// <inheritdoc />
public override void Configure()
{
Module.Configure<WorkflowRuntimeFeature>(workflowRuntime => workflowRuntime.WorkflowStateExporter = sp => ActivatorUtilities.CreateInstance<AsyncWorkflowStateExporter>(sp));
}
}

View file

@ -72,7 +72,7 @@ public class WorkflowRuntimeFeature : FeatureBase
/// <summary>
/// A factory that instantiates an <see cref="IWorkflowStateExporter"/>.
/// </summary>
public Func<IServiceProvider, IWorkflowStateExporter> WorkflowStateExporter { get; set; } = sp => sp.GetRequiredService<NoopWorkflowStateExporter>();
public Func<IServiceProvider, IWorkflowStateExporter> WorkflowStateExporter { get; set; } = ActivatorUtilities.GetServiceOrCreateInstance<NoopWorkflowStateExporter>;
/// <summary>
/// A factory that instantiates an <see cref="ITaskDispatcher"/>.
@ -145,8 +145,6 @@ public class WorkflowRuntimeFeature : FeatureBase
.AddWorkflowDefinitionProvider<ClrWorkflowDefinitionProvider>()
// Workflow state exporter.
.AddSingleton<NoopWorkflowStateExporter>()
.AddSingleton<AsyncWorkflowStateExporter>()
.AddSingleton(WorkflowStateExporter)
// Domain handlers.

View file

@ -63,7 +63,7 @@ services
runtime.UseDefaultRuntime(dr => dr.UseEntityFrameworkCore(ef => ef.UseSqlite(sqliteConnectionString)));
runtime.UseExecutionLogRecords(d => d.UseEntityFrameworkCore(ef => ef.UseSqlite()));
runtime.UseExecutionLogRecords(e => e.UseEntityFrameworkCore(ef => ef.UseSqlite(sqliteConnectionString)));
runtime.WorkflowStateExporter = sp => sp.GetRequiredService<AsyncWorkflowStateExporter>();
runtime.UseAsyncWorkflowStateExporter();
})
.UseActivityDefinitions(feature => feature.UseEntityFrameworkCore(ef => ef.UseSqlite(sqliteConnectionString)))
.UseJobs(jobs => jobs.ConfigureOptions = options => options.WorkerCount = 10)