SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Renames and makes async cancel method.

Browse source 
Renames the `CancelAncestorActivatesAsync` method to `CancelAncestorActivitiesAsync` for clarity and makes it a proper async method, ensuring correct asynchronous execution.
This prevents potential issues when cancelling ancestor activities.
This commit is contained in:
Sipke Schoorstra 2025-11-11 16:56:38 +01:00
parent 59bd21f899
commit a12a71f367
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/modules/Elsa.Workflows.Core/Activities/Flowchart/Activities/FlowJoin.cs
View file

@ -43,7 +43,7 @@ public class FlowJoin : Activity, IJoinNode
{
if (Flowchart.CanWaitAllProceed(context))
{
Flowchart.CancelAncestorActivatesAsync(context);
await Flowchart.CancelAncestorActivitiesAsync(context);
await context.CompleteActivityAsync();
}
@ -51,7 +51,7 @@ public class FlowJoin : Activity, IJoinNode
}
case FlowJoinMode.WaitAny:
{
Flowchart.CancelAncestorActivatesAsync(context);
await Flowchart.CancelAncestorActivitiesAsync(context);
await context.CompleteActivityAsync();
break;
}

2
src/modules/Elsa.Workflows.Core/Activities/Flowchart/Activities/Flowchart.cs
View file

@ -351,7 +351,7 @@ public class Flowchart : Container
return flowScope.AllInboundConnectionsVisited(flowGraph, activity);
}
public static async void CancelAncestorActivatesAsync(ActivityExecutionContext context)
public static async Task CancelAncestorActivitiesAsync(ActivityExecutionContext context)
{
var flowchartContext = context.ParentActivityExecutionContext!;
var flowchart = (Flowchart)flowchartContext.Activity;